Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: minor cleanups for MultiIndex.codes #24146

Merged
merged 1 commit into from
Dec 7, 2018
Merged

CLN: minor cleanups for MultiIndex.codes #24146

merged 1 commit into from
Dec 7, 2018

Conversation

topper-123
Copy link
Contributor

Minor cleanup for #23752. The whatsnew didn't parse properly and other small stuff.

@pep8speaks
Copy link

Hello @topper-123! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #24146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24146   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         162      162           
  Lines       51700    51700           
=======================================
  Hits        47670    47670           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/frozen.py 92.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f492be6...185b780. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 7, 2018 •
edited
Loading

Codecov Report

Merging #24146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24146   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         162      162           
  Lines       51700    51700           
=======================================
  Hits        47670    47670           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/frozen.py 92.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f492be6...185b780. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit 809c0f4 into pandas-dev:master Dec 7, 2018
@jorisvandenbossche
Copy link
Member

Thanks!

@topper-123 topper-123 deleted the multiindex_codes branch December 9, 2018 18:48
@jreback
Copy link
Contributor

jreback commented Dec 13, 2018

i think some more things need changing

see earnings :
https://travis-ci.org/pandas-dev/pandas/jobs/467305227

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@topper-123 @Pingviinituutti
CLN: minor cleanups for MultiIndex.codes (pandas-dev#24146)
1a7d9f1
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@topper-123 @Pingviinituutti
CLN: minor cleanups for MultiIndex.codes (pandas-dev#24146)
c8ef185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topper-123 @pep8speaks @jorisvandenbossche @jreback